So who wants to call a time of death for good ol' code65536?

[mooms]

My preference would be for people to apply my patches (once I get around to updating them for the latest NP2 version) to alternate NP2 versions and create builds themselves, rather than spin binaries for every variation. Which brings up another problem: the website that you point to only has the binaries, no source code. So even if I wanted to create a modified French version, I cannot.

Yes, i know you will need the sources but sadly the author didn't make them public...
I guess i will continue to use your builds then !

Thanks for answering anyway.

[code65536]

Didn't mean to be that presumptuous.

I think you misinterpreted: I meant that as, "It would be presumptuous for me to claim it as a major project and that's why it never has been listed there."

I don't like you voting alternatives, you should add 3. He Does not have a time, or something like it.

Methinks the poll was in jest...

Yes, i know you will need the sources but sadly the author didn't make them public...

You could try contacting the author to ask for the source. Or, better yet, once the NP2 patches have been updated, you could ask him/her to incorporate my patches into the French builds; this person obviously knows how to compile code, and my patches are not that hard to apply.

[dumpydooby]

My preference would be for people to apply my patches (once I get around to updating them for the latest NP2 version) to alternate NP2 versions and create builds themselves

I have updated your patches up to the most recent stable version, but not the most recent development version. Although I use "Bookmarks Edition" as well, it is maintained as a separate patch.


If you'd like, I can package it up and send it your way for review/release; might save you some trouble of having to update the code yourself.

[code65536]

I have updated your patches up to the most recent stable version, but not the most recent development version. Although I use "Bookmarks Edition" as well, it is maintained as a separate patch.

If you'd like, I can package it up and send it your way for review/release; might save you some trouble of having to update the code yourself.

I appreciate the offer, but I plan to jump straight to the latest version and skip the current "stable" version (in my experience, Florian's "unstable" releases are just as stable as his "stable" ones), and I prefer to do a full review and audit of all the Scintilla and base Notepad2 code changes before updating my patches to a new version, in case there are any pitfalls to be mindful of, new features to take advantage of, etc.

[yumeyao]

Despiting registry-based hijack support (/Z) is directly supported in official notepad2, I don't see any difference that prevent applying your patch(of course some manual processing are needed).

Here is my patches for latest "stable" version which includes works of yours and dumpydooby's and alur's. Ahh, wait, from the comments I added i saw alur has made a patch to your code folding codes, but I forget what's that.
http://www.mediafire.com/?dd0hiurephwo15w


BTW, may I have a feature request? Could you make the blank parts of your "code folding column"(let's call it so) function same as selecting the whole line?

[mr_smartepants]

Here's a stupid question regarding the code folding:
When the code is folded into a "header", If I select the folded header, the subsequent lines are NOT selected. Meaning, if I wanted an easy way to delete an entire section, I would fold the code, select the section to delete and then hit the delete button. Unfold the code and only that one "header" line is deleted, not the whole section.
Am I doing something wrong, or is that by design?

Thanks code for the (pending) updates! I love NP2 with your patches.

[dumpydooby]

I have updated your patches up to the most recent stable version, but not the most recent development version. Although I use "Bookmarks Edition" as well, it is maintained as a separate patch.

If you'd like, I can package it up and send it your way for review/release; might save you some trouble of having to update the code yourself.

I appreciate the offer, but I plan to jump straight to the latest version and skip the current "stable" version (in my experience, Florian's "unstable" releases are just as stable as his "stable" ones), and I prefer to do a full review and audit of all the Scintilla and base Notepad2 code changes before updating my patches to a new version, in case there are any pitfalls to be mindful of, new features to take advantage of, etc.

Fair enough. I also wanted to just say that it's only happenstance that my patches are good through the most recent stable release. I was keeping up with the developmental builds prior to it. I just haven't looked at the patches in a couple months but I had every intention of eventually updating them to the latest developmental build.

Can I send you some keyword updates for you to implement in your release? Notepad2 has decent HTML5 support, but it is missing virtually all of the new event attributes. It also needs to be modified to include "data-*" (where * can be anything) attributes (valid in HTML 5). Also I think scintilla didn't have support for AutoIt UDF keywords back when you made your patches (so to include them would require adding them to the list of functions, which would be a bit cumbersome), but it does now and I added all of those. And I added ActionScript to the mix based on the JavaScript lexer.

I think those are the only code highlighting modifications I made, but I'm not positive. Let me know if you're interested and I'll have a closer look and send it your way. If you're not interested, then I'll simply release my changes as a separate patch to supplement yours.

[dumpydooby]

Here's a stupid question regarding the code folding:
When the code is folded into a "header", If I select the folded header, the subsequent lines are NOT selected. Meaning, if I wanted an easy way to delete an entire section, I would fold the code, select the section to delete and then hit the delete button. Unfold the code and only that one "header" line is deleted, not the whole section.
Am I doing something wrong, or is that by design?

Thanks code for the (pending) updates! I love NP2 with your patches.

Select the folded line and then select the line feed to the line below (it might be easier to have a blank line after the fold so that you can simply select the folded line and the blank line). That will select the entirety of the folded code, which can be copied or deleted or whatever

[RyanVM]

I spotted you out in the wild yesterday Ryan.

errr, wha?

[dumpydooby]

I saw you on MozillaZine. Pretty bizarre to see you without your crown. I could have called you a poopyhead or something and you'd have been completely helpless and unable to ban me.


But I wouldn't do that. <3

[yumeyao]

do you have any interests on the project Madedit? It the best editor i've used ever, supporting seamless hex-edit also.

No. I'm very loyal primarily to NP2 and secondarily to Scintilla because of Scintilla's versatility, maturity, and wide support and development base.

Scintilla is great but NP2 is not that good compared to Scintilla's maturity.

I also noticed a mysterious issue today:

save this text to some file with ANSI encoding, then try opening it with NP2.

Code: Select all

cabarc n flash_addon.cab entries_Flash10.ini flash.ocx swflash.cmd swflash.in_

please remove the trailing space produced by copying.

In my case, NP2 decided it's a unicode file!

Reversely, MadEdit is the only text-editor that detects encoding very well.

[RyanVM]

I saw you on MozillaZine. Pretty bizarre to see you without your crown. I could have called you a poopyhead or something and you'd have been completely helpless and unable to ban me.


But I wouldn't do that. <3

Who says my retribution couldn't span forums

[code65536]

I also noticed a mysterious issue today:

Windows Notepad does the exact same same thing. This is because both NP and NP2 uses the Unicode detection heuristics built into Windows.

There are several well-known test strings that cause the heuristics to fail in Notepad, and they will fail in the same way in NP2 and other text editors that use these same heuristics.

You can always tone down these heuristics, but, with all heuristics, all that you'll be doing is trading false positives for false negatives.

(Florian's official version--at least the one that I most last modified--has additional Unicode checks that make its Unicode detection even more aggressive and there to be even more false positives like this; my builds have always pared this detection aggressiveness down so that it was at the same level of Windows Notepad.)

[yumeyao]

Thanks for the info.

But I just tried unhijacking notepad.exe and it went ok.
I second tried using your notepad2 4.0.22, and it's still messed up.

Any idea?

BTW, this should not be the first time I noticed this issue, I may have occured same things before.

[code65536]

With the test string that you provided, I can reliably reproduce the problem in both Notepad (WinXP) and my last Notepad2 build. I wonder if NP behaves differently for different default locales. In any case, NP2's Unicode detection is implemented entirely using Microsoft's IsTextUnicode API.

[yumeyao]

The answer is I used win7 notepad. Just reproduced it in WinXP notepad.

So I suppose win7 notepad do some more actions in addition to calling IsTextUnicode because notepad2 fails(which is an example that directly calls IsTextUnicode)

[code65536]

The answer is I used win7 notepad. Just reproduced it in WinXP notepad.

So I suppose win7 notepad do some more actions in addition to calling IsTextUnicode because notepad2 fails(which is an example that directly calls IsTextUnicode)

Indeed, Notepad in Windows 7 is different. Specifically, after it calls IsTextUnicode, it checks the reasons that IsTextUnicode gave for its result. If its only reason for flagging text as little-endian UTF-16 is a statistical/heuristic analysis (i.e., there was no BOM or other cues), then it will accept that result only if the file size is at least 100 bytes. Otherwise, it will disregard the statistical analysis.

The likelihood of a false positive in the statistical analysis is higher for short, small files, so they picked an arbitrary line (100 bytes) and disregarded the heuristics for anything smaller than that. It's pretty hackish, but it does help eliminate some false positives (of course, this will result in some new false negatives, but the avoided FPs probably outnumber the new FNs). Note that this check does not apply if the text is flagged as BE UTF-16; only LE results are subject to this adjustment.

I will make this same change to my next build of Notepad2 (and to HashCheck, which also uses IsTextUnicode when processing md5/sfv/etc. files).

Code: Select all

notepad.exe Section .text (0x01001000)
0x1009931: CALL  DWORD PTR [ADVAPI32.DLL!IsTextUnicode]; (0x1001014)
0x1009937: TEST  EAX,EAX
0x1009939: JZ    0x1009949
0x100993B: CMP   DWORD PTR [EBP-0x4],0x2  ; IS_TEXT_UNICODE_STATISTICS
0x100993F: JNE   0x1009949
0x1009941: CMP   DWORD PTR [EBP+0xC],0x64 ; iSize <=> 100 bytes
0x1009945: JGE   0x1009949
0x1009947: XOR   EAX,EAX
0x1009949: LEAVE
0x100994A: RET   0x8

[dumpydooby]

Oh how I've missed you.

[yumeyao]

That makes senses. Thanks.

I investigated into madedit's sources yesterday, finding it uses firefox's charset detecting algorithm plus some self-made check. And by simply looking into madedit's import table, there is no IsTextUnicode present.

[mooms]

I will make this same change to my next build of Notepad2 (and to HashCheck, which also uses IsTextUnicode when processing md5/sfv/etc. files).

cool.

Oh how I've missed you.

indeed.

You're a brillant mind K.L , may God be with you.